I used to dive with a guy who was working to become a scuba instructor. At the time we met, he was dating a diver. That relationship ended....we saw him ALOT. But then he started dating a non-diver and now we rarely see him. I know he is happy now and ultimately that is the important thing.
I can't imagine have a SO (my much younger staff tells me significant other is the new term to use) who doesn't dive. You would have to be away from them on weekends and dive trips and training. I can understand where someone dating a diver would get frustrated.
But I also can't imagine giving up diving...for anyone. I don't have children....perhaps if I did I would give it up to be with them more....but for anyone else.....I don't think I would give it up for anyone.